[PATCH] D35994: Debug info for variables whos type is shrinked to bool

[David Blaikie via llvm-commits]

On Tue, Aug 1, 2017 at 7:33 AM Paul Robinson via Phabricator <
reviews at reviews.llvm.org> wrote:

> probinson added inline comments.
>
>
> ================
> Comment at: test/Transforms/GlobalOpt/static-global-boolean-dwarf.ll:2
> +; RUN: opt -f %s -globalopt -o %t
> +; llvm-dwarfdump %t | FileCheck %s
> +
> ----------------
> It would be more usual to pipe the output of opt directly to
> llvm-dwarfdump, unless opt can't do that.
> (It helps the tests run faster to avoid writing files unless you really
> have to.)
>

Yep (& opt can do it ("-o -")). Also usually the input file is streamed in
("< %s") this avoids the input filename becoming part of the output and
possibly accidentally messing with CHECKs on the output.


>
>
> ================
> Comment at: test/Transforms/GlobalOpt/static-global-boolean-dwarf.ll:128
> +
> +; CHECK:   DW_AT_name [DW_FORM_strp] {{.*}} "foo"
> +; CHECK-NEXT:   DW_AT_type
> ----------------
> These checks verify that something named "foo" has debug info of some
> kind, but without verifying any details.  I'd rather see verification of
> the location expression, and possibly the type, given that you are planning
> to change those in the future to describe the shrunk variable.
>
>
> https://reviews.llvm.org/D35994
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170801/5009b5a5/attachment.html>