[PATCH] D35994: Debug info for variables whos type is shrinked to bool

[Paul Robinson via Phabricator via llvm-commits]

probinson added inline comments.


================
Comment at: test/Transforms/GlobalOpt/static-global-boolean-dwarf.ll:2
+; RUN: opt -f %s -globalopt -o %t
+; llvm-dwarfdump %t | FileCheck %s
+
----------------
It would be more usual to pipe the output of opt directly to llvm-dwarfdump, unless opt can't do that.
(It helps the tests run faster to avoid writing files unless you really have to.)


================
Comment at: test/Transforms/GlobalOpt/static-global-boolean-dwarf.ll:128
+
+; CHECK:   DW_AT_name [DW_FORM_strp] {{.*}} "foo"
+; CHECK-NEXT:   DW_AT_type
----------------
These checks verify that something named "foo" has debug info of some kind, but without verifying any details.  I'd rather see verification of the location expression, and possibly the type, given that you are planning to change those in the future to describe the shrunk variable.


https://reviews.llvm.org/D35994