[PATCH] D35302: [IRCE] Recognize loops with unsigned latch conditions

[Max Kazantsev via Phabricator via llvm-commits]

mkazantsev added inline comments.


================
Comment at: lib/Transforms/Scalar/InductiveRangeCheckElimination.cpp:846
+    SignedPredicate = Pred == ICmpInst::ICMP_SLT || Pred == ICmpInst::ICMP_SGT;
+    ICmpInst::Predicate GuardPred =
+        SignedPredicate ? CmpInst::ICMP_SLT : CmpInst::ICMP_ULT;
----------------
anna wrote:
> Pls name this as the `PredOpCode`. I got confused with guards..
Renamed to `BoundPred` to avoid confusion. Semantically it is a predicate we need to check to make sure that the indvar lies within bounds.


https://reviews.llvm.org/D35302