[PATCH] D36107: [PostDom] document the current handling of infinite loops and unreachables

[Tobias Grosser via Phabricator via llvm-commits]

grosser added a comment.

@kuhar, @dberlin : I came up with these test cases while reviewing https://reviews.llvm.org/D36107.

I understand that these test cases will be changed in the future. However, I think these test cases are useful to understand the problem https://reviews.llvm.org/D36107 intends to resolve and the impact the chosen solution has. While we already have quite some test coverage thanks to @kuhar, we have little tests that verify
the update behavior of PDT after changes that introduce/remove virtual nodes. This is shown by the fact, that the first test case (construction of unreachables) illustrates a bug where we forget to add a new virtual exit node.

I would like to commit this change, to have some more test coverage for https://reviews.llvm.org/D36107 and especially to make the impact of https://reviews.llvm.org/D36017 more clear.


https://reviews.llvm.org/D36107