[PATCH] D36107: [PostDom] document the current handling of infinite loops and unreachables

Tobias Grosser via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 31 13:12:16 PDT 2017


grosser created this revision.

As we are in the process of changing the behavior of how the post-dominator tree
is computed, make sure we have some more test coverage in this area.

Current inconsistencies:

- Newly unreachable nodes are not added as new roots, in case the PDT is updated but not rebuilt.
- Newly unreachable loops are not added to the CFG at all (neither when building from scratch nor when updating the CFG). This is inconsistent with the fact that unreachables are added to the PDT, but unreachable loops not. On the other side, PDT relationships are not loosened at the moment in cases where new unreachable loops are built.

This commit is providing additional test coverage for
https://reviews.llvm.org/D35851


https://reviews.llvm.org/D36107

Files:
  unittests/IR/DominatorTreeTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D36107.108983.patch
Type: text/x-patch
Size: 5556 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170731/15fec369/attachment.bin>


More information about the llvm-commits mailing list