[PATCH] D30913: [NFC] Feature generic options to setup start/stop-after/before

[Quentin Colombet via Phabricator via llvm-commits]

qcolombet added inline comments.


================
Comment at: include/llvm/Target/TargetMachine.h:228-231
+  virtual bool addPassesToEmitFile(PassManagerBase &, raw_pwrite_stream &,
+                                   CodeGenFileType,
+                                   bool /*DisableVerify*/ = true,
+                                   MachineModuleInfo **MMI = nullptr) {
----------------
MatzeB wrote:
> I wonder if instead of setting an external `MachineModuleInfo **MMI` you could instead use whatever the user passes in and make this a `MachineModuleInfo *MMI`.
That would mean that if the users create the information, we won't have a way to get back them something they can use.
Concretely, that would mean we would need to always create the MachineModuleInfo in llc, which is fine.

I don't care either way either :).

That said, I like the fact that this API will make it clear that if you pass something it is used. I'll update and coming hopefully shortly.


https://reviews.llvm.org/D30913