[PATCH] D35742: [Driver] Register effective triple before get arm float abi.

[Leo Li via Phabricator via llvm-commits]

aoli added inline comments.


================
Comment at: lib/Driver/Driver.cpp:1311
+      const llvm::Triple Triple(TC.ComputeEffectiveClangTriple(C.getArgs()));
+      RegisterEffectiveTriple TripleRAII(TC, Triple);
       llvm::outs() << TC.getCompilerRT(C.getArgs(), "builtins") << "\n";
----------------
compnerd wrote:
> Is there any reason to not hoist this irrespective of the runtime type?  Basically, if we are going to be printing the "libgcc" filename, we compute and register the effective triple before we determine the location.
It is not required to register the effective triple before printing `libgcc` filename. We only need to do so for compiler-rt runtimes. Is there any benefit to hoist this irrespective of the runtime type?


https://reviews.llvm.org/D35742