[PATCH] D35742: [Driver] Register effective triple before get arm float abi.

Saleem Abdulrasool via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 28 22:44:41 PDT 2017


compnerd added inline comments.


================
Comment at: lib/Driver/Driver.cpp:1311
+      const llvm::Triple Triple(TC.ComputeEffectiveClangTriple(C.getArgs()));
+      RegisterEffectiveTriple TripleRAII(TC, Triple);
       llvm::outs() << TC.getCompilerRT(C.getArgs(), "builtins") << "\n";
----------------
Is there any reason to not hoist this irrespective of the runtime type?  Basically, if we are going to be printing the "libgcc" filename, we compute and register the effective triple before we determine the location.


https://reviews.llvm.org/D35742





More information about the llvm-commits mailing list