[PATCH] D34600: [Error] add expectSuccess()

Zachary Turner via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 28 17:57:10 PDT 2017


I'm not crazy about the 'andGet' versions of the names. Too verbose imo. I
like the first two though.

Sorry I haven't followed up on this btw, been on vacation for 3 weeks
On Fri, Jul 28, 2017 at 4:31 PM Lang Hames via Phabricator <
reviews at reviews.llvm.org> wrote:

> lhames added a comment.
>
> Ping. Zachery - do you have a preference on the names?
>
> assertSuccess and assertSuccessAndGet?
> expectSuccess and expectSuccessAndGet?
>
>
> https://reviews.llvm.org/D34600
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170729/edf36bb4/attachment.html>


More information about the llvm-commits mailing list