[PATCH] D36028: [sanitizer_common] Fuchsia support for interceptors

Roland McGrath via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 28 17:18:53 PDT 2017


mcgrathr marked 2 inline comments as done.
mcgrathr added inline comments.


================
Comment at: lib/sanitizer_common/sanitizer_platform_interceptors.h:40
 #endif
 
 #if SANITIZER_ANDROID
----------------
vitalybuka wrote:
> Could you please add some sanity check like:
> #if SI_POSIX == SI_WINDOWS
> #error 
Done in D36038


================
Comment at: lib/sanitizer_common/sanitizer_platform_interceptors.h:78
 
-#if !SANITIZER_WINDOWS && !SANITIZER_MAC
 # define SI_UNIX_NOT_MAC 1
----------------
vitalybuka wrote:
> SHould this be 
> 
> $if SANITIZER_POSIX  && !SANITIZER_MAC
Done in D36038


Repository:
  rL LLVM

https://reviews.llvm.org/D36028





More information about the llvm-commits mailing list