[PATCH] D36028: [sanitizer_common] Fuchsia support for interceptors

[Vitaly Buka via Phabricator via llvm-commits]

vitalybuka added a comment.

Could you please split WINDOWS->POSIX and Fuchsia changes into different patches so that we land refactoring first.



================
Comment at: lib/sanitizer_common/sanitizer_platform_interceptors.h:40
 #endif
 
 #if SANITIZER_ANDROID
----------------
Could you please add some sanity check like:
#if SI_POSIX == SI_WINDOWS
#error 


================
Comment at: lib/sanitizer_common/sanitizer_platform_interceptors.h:78
 
-#if !SANITIZER_WINDOWS && !SANITIZER_MAC
 # define SI_UNIX_NOT_MAC 1
----------------
SHould this be 

$if SANITIZER_POSIX  && !SANITIZER_MAC


Repository:
  rL LLVM

https://reviews.llvm.org/D36028