[PATCH] D35962: Separate the ICP total threshold and remaining threshold.

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson accepted this revision.
tejohnson added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lib/Analysis/IndirectCallPromotionAnalysis.cpp:47
+    "icp-remaining-percent-threshold", cl::init(30), cl::Hidden, cl::ZeroOrMore,
+    cl::desc("The percentage threshold against remaining unpromoted indirect "
+             "call count for the promotion"));
----------------
danielcdh wrote:
> tejohnson wrote:
> > In your 99.9% and  0.1% case, won't the 0.1% still get promoted since it is 100% of the remaining count after promoting the 99.9% target?
> Before the patch, yes, but with the patch, the 0.1% will be lower than the 5% threshold, thus it will not be promoted.
Got it - I was thinking the remaining count check was the new one, but it is essentially the old one.


https://reviews.llvm.org/D35962