[PATCH] D35962: Separate the ICP total threshold and remaining threshold.

[Dehao Chen via Phabricator via llvm-commits]

danielcdh added inline comments.


================
Comment at: lib/Analysis/IndirectCallPromotionAnalysis.cpp:47
+    "icp-remaining-percent-threshold", cl::init(30), cl::Hidden, cl::ZeroOrMore,
+    cl::desc("The percentage threshold against remaining unpromoted indirect "
+             "call count for the promotion"));
----------------
tejohnson wrote:
> In your 99.9% and  0.1% case, won't the 0.1% still get promoted since it is 100% of the remaining count after promoting the 99.9% target?
Before the patch, yes, but with the patch, the 0.1% will be lower than the 5% threshold, thus it will not be promoted.


https://reviews.llvm.org/D35962