[PATCH] D35737: [GSel]: Support Widening G_ICMP's destination operand.

Aditya Nandakumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 26 15:04:02 PDT 2017


aditya_nandakumar marked an inline comment as done.
aditya_nandakumar added inline comments.


================
Comment at: lib/CodeGen/GlobalISel/LegalizerHelper.cpp:617
+    if (TypeIdx == 0)
+      MIRBuilder.buildInstr(TargetOpcode::G_FPTRUNC, MI.getOperand(0).getReg(),
+                            DstReg);
----------------
volkan wrote:
> The result type is boolean. Why do we need to build a G_FPTRUNC  instead of G_TRUNC? 
Good point. I used G_FPTRUNC to be consistent - but I guess it makes more sense to use G_TRUNC here. I'll update it.


https://reviews.llvm.org/D35737





More information about the llvm-commits mailing list