[PATCH] D35909: [lit] Port googletest lit tests to Windows

Reid Kleckner via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 26 14:24:22 PDT 2017


On Wed, Jul 26, 2017 at 1:07 PM, Zachary Turner <zturner at google.com> wrote:

> Would it be more robust to interpret the shebang ourselves? The current
> method relies on future script writers to know that it must end in .py. We
> could interpret the shebang ourselves though and run Python if it's present
>

It's slower, and I think there is too much variety in possibly valid python
shebang lines. There are also no known implementations of googletest output
in Python. The only reason we're doing this is to avoid a dependency on
native gtest executables from lit's test suite.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170726/d2947011/attachment.html>


More information about the llvm-commits mailing list