[PATCH] D35909: [lit] Port googletest lit tests to Windows

[Zachary Turner via llvm-commits]

Would it be more robust to interpret the shebang ourselves? The current
method relies on future script writers to know that it must end in .py. We
could interpret the shebang ourselves though and run Python if it's present
On Wed, Jul 26, 2017 at 12:19 PM Brian Gesiak via Phabricator via
llvm-commits <llvm-commits at lists.llvm.org> wrote:

> modocache requested changes to this revision.
> modocache added a comment.
> This revision now requires changes to proceed.
>
> LGTM, but I want to double-check this passes for me locally. Also, I think
> you may have left some debugging code in here.
>
>
>
> ================
> Comment at: llvm/utils/lit/lit/formats/googletest.py:92
>                  # Discover the tests in this executable.
> +                litConfig.warning(subdir)
>                  execpath = os.path.join(source_path, subdir, fn)
> ----------------
> My guess is that you may have added this for your own debugging? Or is
> this intentional?
>
>
> ================
> Comment at: llvm/utils/lit/tests/googletest-format.py:9
>  # CHECK: -- Testing:
> -# CHECK: PASS: googletest-format :: DummySubDir/OneTest/FirstTest.subTestA
> -# CHECK: FAIL: googletest-format :: DummySubDir/OneTest/FirstTest.subTestB
> -# CHECK-NEXT: *** TEST 'googletest-format ::
> DummySubDir/OneTest/FirstTest.subTestB' FAILED ***
> +# CHECK: PASS: googletest-format ::
> {{[Dd]ummy[Ss]ub[Dd]ir}}/OneTest.py/FirstTest.subTestA
> +# CHECK: FAIL: googletest-format ::
> {{[Dd]ummy[Ss]ub[Dd]ir}}/OneTest.py/FirstTest.subTestB
> ----------------
> This is interesting, why do we need to handle upper- and lower-case here?
> Could you explain this in the commit message?
>
>
> https://reviews.llvm.org/D35909
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170726/8e5057b5/attachment.html>