[PATCH] D35845: [Polly][ScheduleOptimizer] Translate to C++ bindings

[Roman via Phabricator via llvm-commits]

gareevroman added a comment.

In https://reviews.llvm.org/D35845#820452, @Meinersbur wrote:

> Very straightforward. ++


Thanks for the review!

> The only thing that surprised me was that the `static` keywords have been removed. I think you put those functions in unnamed namespaces instead. This is ok, but not related to the isl++ bindings. If possible, can you commit that in a separate commit?

Ok.



================
Comment at: lib/Transform/ScheduleOptimizer.cpp:644
   if (isMatMulOperandAcc(AccMap, MMI.i, MMI.j) && !MMI.ReadFromC &&
-      isl_map_n_basic_map(AccMap) == 1) {
+      isl_map_n_basic_map(AccMap.get()) == 1) {
     MMI.ReadFromC = MemAccess;
----------------
Meinersbur wrote:
> `n_basic_map` missing from the interface?
It seems that lib/External/isl/include/isl-noexceptions.h doesn't contain it. I propose to extend the interface in a separate commit.


https://reviews.llvm.org/D35845