[PATCH] D35845: [Polly][ScheduleOptimizer] Translate to C++ bindings

[Michael Kruse via Phabricator via llvm-commits]

Meinersbur accepted this revision.
Meinersbur added a comment.
This revision is now accepted and ready to land.

Very straightforward. ++

The only thing that surprised me was that the `static` keywords have been removed. I think you put those functions in unnamed namespaces instead. This is ok, but not related to the isl++ bindings. If possible, can you commit that in a separate commit?



================
Comment at: lib/Transform/ScheduleOptimizer.cpp:560
 ///                   the requirements, isl_stat_error otherwise.
-static isl_stat isMatMulOperandConstraint(__isl_keep isl_constraint *Constraint,
-                                          int &DimInPos, int &DimOutPos) {
----------------
Why was the `static` removed?

Replace `isl_stat` by `isl::stat`?


================
Comment at: lib/Transform/ScheduleOptimizer.cpp:639
 ///                  false, otherwise.
-static bool isMatMulNonScalarReadAccess(MemoryAccess *MemAccess,
-                                        MatMulInfoTy &MMI) {
+bool isMatMulNonScalarReadAccess(MemoryAccess *MemAccess, MatMulInfoTy &MMI) {
   if (!MemAccess->isLatestArrayKind() || !MemAccess->isRead())
----------------
`static`?


================
Comment at: lib/Transform/ScheduleOptimizer.cpp:644
   if (isMatMulOperandAcc(AccMap, MMI.i, MMI.j) && !MMI.ReadFromC &&
-      isl_map_n_basic_map(AccMap) == 1) {
+      isl_map_n_basic_map(AccMap.get()) == 1) {
     MMI.ReadFromC = MemAccess;
----------------
`n_basic_map` missing from the interface?


https://reviews.llvm.org/D35845