[PATCH] D35879: [lit] Mark several of lit's tests XFAIL on Windows

[Dan Liew via Phabricator via llvm-commits]

delcypher added inline comments.


================
Comment at: utils/lit/tests/lit.cfg:57
+if sys.platform.startswith('win') or sys.platform.startswith('cygwin'):
+    config.available_features.add('windows')
----------------
delcypher wrote:
> I've only ever used `config.available_features` with the `REQUIRES:` declaration. Does it work with `XFAIL:` too? I thought `XFAIL:` just took a target architecture?
Hmm looks like things have changed a lot since I last looked.

https://reviews.llvm.org/D18185

I was half right. In `Test.isExpectedToFail()` (`lit/Test.py`) I can see that the boolean expression evaluator  takes the features and the target triple.

So I guess `XFAIL: windows` is fine.


https://reviews.llvm.org/D35879