[PATCH] D35879: [lit] Mark several of lit's tests XFAIL on Windows

Dan Liew via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 26 02:07:56 PDT 2017


delcypher added a comment.

Looks fine. The only bit I'm not sure about is the interaction of `config.available_features` and `XFAIL`.



================
Comment at: utils/lit/tests/lit.cfg:57
+if sys.platform.startswith('win') or sys.platform.startswith('cygwin'):
+    config.available_features.add('windows')
----------------
I've only ever used `config.available_features` with the `REQUIRES:` declaration. Does it work with `XFAIL:` too? I thought `XFAIL:` just took a target architecture?


https://reviews.llvm.org/D35879





More information about the llvm-commits mailing list