[PATCH] D35797: [ELF] - Implement --warn-once.

[Rafael Avila de Espindola via llvm-commits]

I am fine with ignoring

On July 25, 2017 1:41:44 AM PDT, George Rimar <grimar at accesssoftek.com> wrote:
>>> --- ELF/Symbols.h
>>> +++ ELF/Symbols.h
>>> @@ -206,6 +206,9 @@
>>>    static bool classof(const SymbolBody *S) {
>>>      return S->kind() == UndefinedKind;
>>>    }
>>> +
>>> +  // Used for error reporting. True if symbol was reported.
>>> +  unsigned Reported : 1;
>>>  };
>>
>>This changes sizeof(Undefined), no? Can that be avoided?
>>
>>Cheers,
>>Rafael
>
>Probably. I supposed changing of body is not critical though. 
>But anyways before we do anything: Rui suggests to ignore --warn-once.
>
>We also have fresh PR33906 requesting for support or ignore ether.
>
>So will you be fine with just ignoring it ?
>
>FWIW I still think it may be convinent for reviewing linkage errors,
>but I am fine with ignoring it too.
>
>George.

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170725/9377a9c3/attachment.html>