[PATCH] D35797: [ELF] - Implement --warn-once.

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 25 01:41:44 PDT 2017


>> --- ELF/Symbols.h
>> +++ ELF/Symbols.h
>> @@ -206,6 +206,9 @@
>>    static bool classof(const SymbolBody *S) {
>>      return S->kind() == UndefinedKind;
>>    }
>> +
>> +  // Used for error reporting. True if symbol was reported.
>> +  unsigned Reported : 1;
>>  };
>
>This changes sizeof(Undefined), no? Can that be avoided?
>
>Cheers,
>Rafael

Probably. I supposed changing of body is not critical though. 
But anyways before we do anything: Rui suggests to ignore --warn-once.

We also have fresh PR33906 requesting for support or ignore ether.

So will you be fine with just ignoring it ?

FWIW I still think it may be convinent for reviewing linkage errors,
but I am fine with ignoring it too.

George.


More information about the llvm-commits mailing list