[PATCH] D35014: [X86] PR32755 : Improvement in CodeGen instruction selection for LEAs.

[Jatin Bhateja via Phabricator via llvm-commits]

jbhateja added inline comments.


================
Comment at: test/CodeGen/X86/lea-opt-csebb.ll:1
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+
----------------
lsaba wrote:
> can you please add a test case that covers scale >1 cases 

This commit if you see has two parts
1/ pattern matching based on addressing mode (which is limited currently).
2/ factoring of LEAs which is generic.

Checking in incremental changes should be fine I guess.

Generic pattern will need to be brought out of addessing mode based selection as I described in following link 
https://groups.google.com/forum/#!topic/llvm-dev/x2LDXpON500

Please comment in the thread. 



================
Comment at: test/CodeGen/X86/umul-with-overflow.ll:6
 define zeroext i1 @a(i32 %x)  nounwind {
+; CHECK-LABEL: a:
+; CHECK:       # BB#0:
----------------
lsaba wrote:
> why did this test change? 
Beecause I generated its output with script utils/update_llc_test_checks.py which adds 
an assertion for each instruction. I think it sould be fine. 


https://reviews.llvm.org/D35014