[PATCH] D35014: [X86] PR32755 : Improvement in CodeGen instruction selection for LEAs.

[Lama via Phabricator via llvm-commits]

lsaba added inline comments.


================
Comment at: lib/Target/X86/X86OptimizeLEAs.cpp:342
+   if (Itr == LEAs.end()) {
+       lsize = 0;
+       LEAs[Key].push_front(MI);
----------------
already initialized at the beginning of the function


================
Comment at: test/CodeGen/X86/lea-opt-csebb.ll:1
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+
----------------
can you please add a test case that covers scale >1 cases 


================
Comment at: test/CodeGen/X86/umul-with-overflow.ll:6
 define zeroext i1 @a(i32 %x)  nounwind {
+; CHECK-LABEL: a:
+; CHECK:       # BB#0:
----------------
why did this test change? 


https://reviews.llvm.org/D35014