[PATCH] D35299: [AArch64] Tie source and destination operands for AESMC/AESIMC.

Tim Northover via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 21 13:44:04 PDT 2017


t.p.northover added a comment.

> I'm not entirely sure what you mean here.

I downloaded and built the very first patch, and the obvious test/MC/AArch64 tests failed because they expected "aesmc v0.16b, v1.16b" to be valid syntax. It's not an issue with the newest patch but it confirms evandro's suspicion about the earlier one.

> Yes, the single-use case is what we should see in practice. I've removed the single use pattern from the patch.

Thanks. I don't know about @evandro, but I think this is looking pretty reasonable now. I certainly can't think of a fundamentally better approach.


https://reviews.llvm.org/D35299





More information about the llvm-commits mailing list