[PATCH] D32249: [PartialInl] Enhance partial inliner to handle more complex conditions

[David Li via Phabricator via llvm-commits]

davidxl added inline comments.


================
Comment at: llvm/trunk/lib/Transforms/IPO/PartialInlining.cpp:299
+      PHINode *Phi = dyn_cast<PHINode>(I);
+      if (!Phi)
+        break;
----------------
gyiu wrote:
> @davidxl Please correct me if I'm wrong, but in this loop, if the first instruction in the BB is not a PHINode we give up?  If that's the case, then wouldn't 'Phi' be the first and only Phi we'll find?
The method returns the first phi of the block if it exists.  It should  add this:

if (isa<DbgInfoIntrinsic>(I))
   continue;


Repository:
  rL LLVM

https://reviews.llvm.org/D32249