[PATCH] D32249: [PartialInl] Enhance partial inliner to handle more complex conditions

Graham Yiu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 21 12:23:07 PDT 2017


gyiu added inline comments.


================
Comment at: llvm/trunk/lib/Transforms/IPO/PartialInlining.cpp:299
+      PHINode *Phi = dyn_cast<PHINode>(I);
+      if (!Phi)
+        break;
----------------
@davidxl Please correct me if I'm wrong, but in this loop, if the first instruction in the BB is not a PHINode we give up?  If that's the case, then wouldn't 'Phi' be the first and only Phi we'll find?


Repository:
  rL LLVM

https://reviews.llvm.org/D32249





More information about the llvm-commits mailing list