[PATCH] D35686: [mips] Support -membedded-data and fix a related bug

Simon Dardis via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 20 15:20:18 PDT 2017


sdardis marked an inline comment as done.
sdardis added inline comments.


================
Comment at: lib/Target/Mips/MipsTargetObjectFile.cpp:158
                                                        unsigned &Align) const {
-  if (IsConstantInSmallSection(DL, C, *TM))
+  if (IsConstantInSmallSection(DL, C, *TM))// && !EmbeddedData)
     return SmallDataSection;
----------------
atanasyan wrote:
> Do we really need this comment? Its meaning is not obvious.
Hm, left over code from development. I'll remove before committing.


Repository:
  rL LLVM

https://reviews.llvm.org/D35686





More information about the llvm-commits mailing list