[PATCH] D35686: [mips] Support -membedded-data and fix a related bug

[Simon Atanasyan via Phabricator via llvm-commits]

atanasyan accepted this revision.
atanasyan added a comment.
This revision is now accepted and ready to land.

LGTM with minor nits.



================
Comment at: lib/Target/Mips/MipsTargetObjectFile.cpp:158
                                                        unsigned &Align) const {
-  if (IsConstantInSmallSection(DL, C, *TM))
+  if (IsConstantInSmallSection(DL, C, *TM))// && !EmbeddedData)
     return SmallDataSection;
----------------
Do we really need this comment? Its meaning is not obvious.


Repository:
  rL LLVM

https://reviews.llvm.org/D35686