[PATCH] D35518: [COFF, ARM64, CodeView] Add support to emit CodeView debug info for ARM64 COFF

[Reid Kleckner via Phabricator via llvm-commits]

rnk added inline comments.


================
Comment at: lib/CodeGen/AsmPrinter/AsmPrinter.cpp:307
                                      CodeViewLineTablesGroupDescription));
-    }
-    if (!EmitCodeView || MMI->getModule()->getDwarfVersion()) {
+    } else if (!EmitCodeView || MMI->getModule()->getDwarfVersion()) {
       DD = new DwarfDebug(this, &M);
----------------
mgrang wrote:
> majnemer wrote:
> > Hrm, why isn't this just `if (MMI->getModule()->getDwarfVersion())` ?
> In order to emit CodeView info for COFF, we need to pass -g -gcodeview. I wanted to make this an else-if since otherwise it will always emit Dwarf info as well (due to the presence of -g).
I don't think that'll happen, I don't see any "Dwarf Version" metadata when I run `clang -S -emit-llvm -g -gcodeview t.c -o -`.


Repository:
  rL LLVM

https://reviews.llvm.org/D35518