[PATCH] D35518: [COFF, ARM64, CodeView] Add support to emit CodeView debug info for ARM64 COFF

[Mandeep Singh Grang via Phabricator via llvm-commits]

mgrang added inline comments.


================
Comment at: lib/CodeGen/AsmPrinter/AsmPrinter.cpp:307
                                      CodeViewLineTablesGroupDescription));
-    }
-    if (!EmitCodeView || MMI->getModule()->getDwarfVersion()) {
+    } else if (!EmitCodeView || MMI->getModule()->getDwarfVersion()) {
       DD = new DwarfDebug(this, &M);
----------------
majnemer wrote:
> Hrm, why isn't this just `if (MMI->getModule()->getDwarfVersion())` ?
In order to emit CodeView info for COFF, we need to pass -g -gcodeview. I wanted to make this an else-if since otherwise it will always emit Dwarf info as well (due to the presence of -g).


Repository:
  rL LLVM

https://reviews.llvm.org/D35518