[PATCH] D35605: LTO: Export functions referenced by the CFI jump table.

[Peter Collingbourne via Phabricator via llvm-commits]

pcc marked an inline comment as done.
pcc added inline comments.


================
Comment at: llvm/lib/LTO/LTO.cpp:1079
+      ExportedGUIDs.insert(
+          GlobalValue::getGUID(GlobalValue::dropLLVMManglingEscape(Def)));
+
----------------
tejohnson wrote:
> Not for this patch, but as an aside - can dropLLVMMangingEscape be called unconditionally from within GlobalValue::getGUID, instead of callers needing to know when it must be invoked? I see that GlobalValue::getGlobalIdentifier also unconditionally does this (although not via dropLLVMMangingEscape - it should probably be refactored to just invoke that helper).
Maybe once we figure out what to do about GUIDs in general... as you know I'm not sure if we should be using them outside of PGO.


https://reviews.llvm.org/D35605