[PATCH] D35605: LTO: Export functions referenced by the CFI jump table.

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson accepted this revision.
tejohnson added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/lib/LTO/LTO.cpp:1079
+      ExportedGUIDs.insert(
+          GlobalValue::getGUID(GlobalValue::dropLLVMManglingEscape(Def)));
+
----------------
Not for this patch, but as an aside - can dropLLVMMangingEscape be called unconditionally from within GlobalValue::getGUID, instead of callers needing to know when it must be invoked? I see that GlobalValue::getGlobalIdentifier also unconditionally does this (although not via dropLLVMMangingEscape - it should probably be refactored to just invoke that helper).


================
Comment at: llvm/test/LTO/Resolution/X86/export-jumptable.ll:1
+; RUN: opt -thinlto-bc -o %t %s
+; RUN: llvm-lto2 run -o %t2 -r %t,f1,p -r %t,f2,p -r %t,_start,px %t -save-temps
----------------
Please document what this test is doing and looking for.


https://reviews.llvm.org/D35605