[PATCH] D35545: [AArch64, COFF] Interpret .align as power of two for COFF as well

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 18 04:14:58 PDT 2017


mstorsjo created this revision.
Herald added subscribers: kristof.beyls, javed.absar, rengolin, aemerson.

Remove some unrelated directives that can't be assembled for COFF from the existing jump table test and rerun that test for windows as well.


https://reviews.llvm.org/D35545

Files:
  lib/Target/AArch64/MCTargetDesc/AArch64MCAsmInfo.cpp
  test/MC/AArch64/jump-table.s


Index: test/MC/AArch64/jump-table.s
===================================================================
--- test/MC/AArch64/jump-table.s
+++ test/MC/AArch64/jump-table.s
@@ -1,9 +1,9 @@
 // RUN: llvm-mc < %s -triple=aarch64-none-linux-gnu -filetype=obj | llvm-readobj -r | FileCheck %s
+// RUN: llvm-mc < %s -triple=aarch64-windows-gnu
 
 	.file	"<stdin>"
 	.text
 	.globl	test_jumptable
-	.type	test_jumptable, at function
 test_jumptable:                         // @test_jumptable
 	.cfi_startproc
 // BB#0:
@@ -31,9 +31,8 @@
 	movz	x0, #8
 	ret
 .Ltmp0:
-	.size	test_jumptable, .Ltmp0-test_jumptable
 	.cfi_endproc
-	.section	.rodata,"a", at progbits
+	.section	.rodata
 	.align	3
 .LJTI0_0:
 	.xword	.LBB0_2
Index: lib/Target/AArch64/MCTargetDesc/AArch64MCAsmInfo.cpp
===================================================================
--- lib/Target/AArch64/MCTargetDesc/AArch64MCAsmInfo.cpp
+++ lib/Target/AArch64/MCTargetDesc/AArch64MCAsmInfo.cpp
@@ -105,4 +105,5 @@
   CommentString = ";";
   PrivateGlobalPrefix = ".L";
   PrivateLabelPrefix = ".L";
+  AlignmentIsInBytes = false;
 }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D35545.107056.patch
Type: text/x-patch
Size: 1088 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170718/cb7703ec/attachment.bin>


More information about the llvm-commits mailing list