[PATCH] D35543: [AArch64] Update a comment in a test

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 18 04:00:59 PDT 2017


mstorsjo created this revision.
Herald added subscribers: kristof.beyls, javed.absar, rengolin, aemerson.

The comment ended up outdated when the test was rewritten in SVN r192281.


https://reviews.llvm.org/D35543

Files:
  test/MC/AArch64/adrp-relocation.s


Index: test/MC/AArch64/adrp-relocation.s
===================================================================
--- test/MC/AArch64/adrp-relocation.s
+++ test/MC/AArch64/adrp-relocation.s
@@ -2,11 +2,10 @@
 // RUN: llvm-mc -target-abi=ilp32 -triple=aarch64-linux-gnu -filetype=obj \
 // RUN: -o - %s| llvm-readobj -r - | FileCheck -check-prefix=CHECK-ILP32 %s
         .text
-// These should produce an ADRP/ADD pair to calculate the address of
-// testfn. The important point is that LLVM shouldn't think it can deal with the
-// relocation on the ADRP itself (even though it knows everything about the
-// relative offsets of testfn and foo) because its value depends on where this
-// object file's .text section gets relocated in memory.
+// This tests that LLVM doesn't think it can deal with the relocation on the ADRP
+// itself (even though it knows everything about the relative offsets of sym and
+// the adrp instruction) because its value depends on where this object file's
+// .text section gets relocated in memory.
         adrp x0, sym
         adrp x0, :got:sym
         adrp x0, :gottprel:sym


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D35543.107052.patch
Type: text/x-patch
Size: 1109 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170718/38351af5/attachment.bin>


More information about the llvm-commits mailing list