[PATCH] D35435: [AMDGPU] Produce flat|global_dwordx3 instructions

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

rampitec added a comment.

In https://reviews.llvm.org/D35435#812242, @arsenm wrote:

> This is the wrong way to handle this. I did most of the work to avoid having to select the machine nodes so early a long time ago. I have the patches to add v3* to MVT. Short of that a new LOAD_V3 node would be better than going direct to the instruction here


V3 is an alien to LLVM, so I had to do it this way. It works.
What about patches for MVT to support V3? Are they anywhere ready to be submitted?



================
Comment at: lib/Target/AMDGPU/AMDGPUISelLowering.cpp:2554
+
+    if (Subtarget->getGeneration() >= AMDGPUSubtarget::GFX9 &&
+        IsGlobalOrConstant)
----------------
arsenm wrote:
> There's a global offset subtarget feature. I also have the patch to start selecting global, but I haven't committed it yet
This is not about offsets, this is about support of global_load instructions, which is started from GFX9. Then flat_load's also have offsets there and that is checked above as Subtarget->hasFlatInstOffsets(). A global offset is actually a feature to support offsetting workitem ids, so unrelated.


https://reviews.llvm.org/D35435