[PATCH] D35435: [AMDGPU] Produce flat|global_dwordx3 instructions

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 17 17:53:51 PDT 2017


arsenm added a comment.

This is the wrong way to handle this. I did most of the work to avoid having to select the machine nodes so early a long time ago. I have the patches to add v3* to MVT. Short of that a new LOAD_V3 node would be better than going direct to the instruction here



================
Comment at: lib/Target/AMDGPU/AMDGPUISelLowering.cpp:2554
+
+    if (Subtarget->getGeneration() >= AMDGPUSubtarget::GFX9 &&
+        IsGlobalOrConstant)
----------------
There's a global offset subtarget feature. I also have the patch to start selecting global, but I haven't committed it yet


https://reviews.llvm.org/D35435





More information about the llvm-commits mailing list