[PATCH] D34042: AMDGPU: Annotate features from x work item/group IDs.

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: lib/Target/AMDGPU/AMDGPUAnnotateKernelFeatures.cpp:221
         if (!Callee)
           continue;
 
----------------
rampitec wrote:
> llvm_unreachable for now.
> In general I guess all functions whose address is taken shall get all the attributes. One tricky point is that bitcast of a function type (for example when calling an alias changing FTy) considered to be a taken address, so some simplification and analysis is needed.
We already error on these calls in codegen with a proper error


https://reviews.llvm.org/D34042