[PATCH] D34042: AMDGPU: Annotate features from x work item/group IDs.

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

rampitec accepted this revision.
rampitec added a comment.
This revision is now accepted and ready to land.

LGTM, with exception of llvm_unreachable for indirect calls.



================
Comment at: lib/Target/AMDGPU/AMDGPUAnnotateKernelFeatures.cpp:221
         if (!Callee)
           continue;
 
----------------
llvm_unreachable for now.
In general I guess all functions whose address is taken shall get all the attributes. One tricky point is that bitcast of a function type (for example when calling an alias changing FTy) considered to be a taken address, so some simplification and analysis is needed.


https://reviews.llvm.org/D34042