[PATCH] D35317: [EarlyCSE] Handle calls with no MemorySSA info.

[Daniel Berlin via llvm-commits]

SGTM, thanks!


On Fri, Jul 14, 2017 at 12:31 PM, Geoff Berry via Phabricator <
reviews at reviews.llvm.org> wrote:

> gberry added a comment.
>
> I'm going to go ahead with this version of the fix (with the comments
> addressed).  I implemented the stronger version (i.e. looking at MSSA
> memory accesses when checking doesNotAccessMemory, onlyReadsMemory,
> mayReadFromMemory, mayWriteMemory) and saw a total of 2 differences in the
> values returned from these checks across all of our benchmarks, and no
> change in code generation at all.  Given the amount of code churn to
> implement this and how close we are to release, I'm going to take the
> conservative route.
>
>
> https://reviews.llvm.org/D35317
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170714/c4a921b8/attachment.html>