[PATCH] D35317: [EarlyCSE] Handle calls with no MemorySSA info.

Geoff Berry via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 14 12:31:53 PDT 2017


gberry added a comment.

I'm going to go ahead with this version of the fix (with the comments addressed).  I implemented the stronger version (i.e. looking at MSSA memory accesses when checking doesNotAccessMemory, onlyReadsMemory, mayReadFromMemory, mayWriteMemory) and saw a total of 2 differences in the values returned from these checks across all of our benchmarks, and no change in code generation at all.  Given the amount of code churn to implement this and how close we are to release, I'm going to take the conservative route.


https://reviews.llvm.org/D35317





More information about the llvm-commits mailing list