[PATCH] D35394: [codeview] Remove TypeServerHandler and PDBTypeServerHandler

[Zachary Turner via llvm-commits]

Is the existing model limiting somehow?
On Thu, Jul 13, 2017 at 4:13 PM Reid Kleckner via Phabricator <
reviews at reviews.llvm.org> wrote:

> rnk created this revision.
> Herald added subscribers: hiraditya, mgorny.
>
> Instead of wiring these through the CVTypeVisitor interface, clients
> should inspect the CVTypeArray before visiting it and potentially load
> up the type server's TPI stream if they need it.
>
> No tests relied on this functionality because LLD was the only client.
>
>
> https://reviews.llvm.org/D35394
>
> Files:
>   lld/COFF/PDB.cpp
>   lld/test/COFF/pdb-type-server-missing.yaml
>   llvm/include/llvm/DebugInfo/CodeView/CVTypeVisitor.h
>   llvm/include/llvm/DebugInfo/CodeView/TypeServerHandler.h
>   llvm/include/llvm/DebugInfo/CodeView/TypeStreamMerger.h
>   llvm/include/llvm/DebugInfo/PDB/Native/PDBTypeServerHandler.h
>   llvm/lib/DebugInfo/CodeView/CVTypeVisitor.cpp
>   llvm/lib/DebugInfo/CodeView/TypeStreamMerger.cpp
>   llvm/lib/DebugInfo/PDB/CMakeLists.txt
>   llvm/lib/DebugInfo/PDB/Native/PDBTypeServerHandler.cpp
>   llvm/lib/DebugInfo/PDB/Native/TpiStream.cpp
>   llvm/tools/llvm-pdbutil/llvm-pdbutil.cpp
>   llvm/tools/llvm-readobj/COFFDumper.cpp
>   llvm/unittests/DebugInfo/CodeView/RandomAccessVisitorTest.cpp
>   llvm/unittests/DebugInfo/PDB/CMakeLists.txt
>   llvm/unittests/DebugInfo/PDB/TypeServerHandlerTest.cpp
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170714/fa3277ba/attachment.html>