Is the existing model limiting somehow?<br><div class="gmail_quote"><div dir="ltr">On Thu, Jul 13, 2017 at 4:13 PM Reid Kleckner via Phabricator <<a href="mailto:reviews@reviews.llvm.org">reviews@reviews.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">rnk created this revision.<br>
Herald added subscribers: hiraditya, mgorny.<br>
<br>
Instead of wiring these through the CVTypeVisitor interface, clients<br>
should inspect the CVTypeArray before visiting it and potentially load<br>
up the type server's TPI stream if they need it.<br>
<br>
No tests relied on this functionality because LLD was the only client.<br>
<br>
<br>
<a href="https://reviews.llvm.org/D35394" rel="noreferrer" target="_blank">https://reviews.llvm.org/D35394</a><br>
<br>
Files:<br>
  lld/COFF/PDB.cpp<br>
  lld/test/COFF/pdb-type-server-missing.yaml<br>
  llvm/include/llvm/DebugInfo/CodeView/CVTypeVisitor.h<br>
  llvm/include/llvm/DebugInfo/CodeView/TypeServerHandler.h<br>
  llvm/include/llvm/DebugInfo/CodeView/TypeStreamMerger.h<br>
  llvm/include/llvm/DebugInfo/PDB/Native/PDBTypeServerHandler.h<br>
  llvm/lib/DebugInfo/CodeView/CVTypeVisitor.cpp<br>
  llvm/lib/DebugInfo/CodeView/TypeStreamMerger.cpp<br>
  llvm/lib/DebugInfo/PDB/CMakeLists.txt<br>
  llvm/lib/DebugInfo/PDB/Native/PDBTypeServerHandler.cpp<br>
  llvm/lib/DebugInfo/PDB/Native/TpiStream.cpp<br>
  llvm/tools/llvm-pdbutil/llvm-pdbutil.cpp<br>
  llvm/tools/llvm-readobj/COFFDumper.cpp<br>
  llvm/unittests/DebugInfo/CodeView/RandomAccessVisitorTest.cpp<br>
  llvm/unittests/DebugInfo/PDB/CMakeLists.txt<br>
  llvm/unittests/DebugInfo/PDB/TypeServerHandlerTest.cpp<br>
<br>
</blockquote></div>