[PATCH] D35384: PGOInstrumentation: Move profile matching warnings to remarks

[David Blaikie via llvm-commits]

On Thu, Jul 13, 2017 at 2:03 PM David Li via Phabricator <
reviews at reviews.llvm.org> wrote:

> davidxl added a comment.
>
> Blindly downgrade the warning into remarks can be bad -- profile mismatch
> problems can go undetected. People may spend more time diagnosing
> performance regressions due to missed warnings. Worse, we may regress in
> compiler without noticing.
>

Any other ideas?

The diagnostic handling callbacks through to Clang aren't granular enough
to demote only this warning to -Wno-error (also as a warning it undermines
the confidence as warnings as actionable things that Clang has helped
provide users).

Is there a way to determine a threshold at which the profile is so out of
alignment that we should tell the user they probably shouldn't use it? That
could be emitted as a warning.

- Dave


>
>
> https://reviews.llvm.org/D35384
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170713/ee6f9ddd/attachment.html>