[PATCH] D35166: [DWARF] Introduce verification for the unit header chain in .debug_info section to llvm-dwarfdump.
Frederic Riss via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jul 13 11:23:08 PDT 2017
friss added a comment.
Just one comment:
================
Comment at: lib/DebugInfo/DWARF/DWARFVerifier.cpp:103-104
+ Success = false;
+ if (isUnitDWARF64)
+ break;
+ }
----------------
I still don't like that isUnitDWARF64 is a member when it's used only for communicating between handleDebugInfoUnitHeaderChain() and verifyUnit(). I think I'd prefer is it was a local variable passed as an out-parameter to verifyUnit.
https://reviews.llvm.org/D35166
More information about the llvm-commits
mailing list