[PATCH] D35166: [DWARF] Introduce verification for the unit header chain in .debug_info section to llvm-dwarfdump.

[Spyridoula Gravani via Phabricator via llvm-commits]

sgravani added inline comments.


================
Comment at: lib/DebugInfo/DWARF/DWARFVerifier.cpp:85
+        OS << "Unit is in 64-bit DWARF format; cannot verify.\n";
+        return true;
+      }
----------------
friss wrote:
> I understand that we do not really support DWARF64, but why make it completely fatal. We could still extract the length of the unit and skip it, right? Of course, I doubt many programs link DWARF64 with 32...
I'm not exactly sure how to "skip" the unit.. I would need to be handling 64-bit offsets in order to get the next Unit in the .debug_info section.  We could do that, but at the moment I prefer not to deal with DWARF64 and stop the verification when we identify a unit in the the 64-bit format.


https://reviews.llvm.org/D35166