[PATCH] D35351: [llvm-readobj] - Teach readobj to print DT_FILTER dynamic tag in human readable form.

Rafael Avila de Espindola via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 13 09:09:59 PDT 2017


George Rimar via Phabricator <reviews at reviews.llvm.org> writes:

> grimar added a comment.
>
> In https://reviews.llvm.org/D35351#807913, @emaste wrote:
>
>> Should we instead switch DT_NEEDED to be like DT_AUXILIARY? This would be similar to the format used by binutils readelf and ELF Tool Chain readelf.
>
>
> Ah, now I see why I did it in that way for DT_AUXILIARY in https://reviews.llvm.org/D24138. I was wondering today why I implemented such a inconsistent output format that time :)
> So do what other think ? Should we be consistent with other readelf utils it seems ?

+1 from me for looking like readelf.

Cheers,
Rafael


More information about the llvm-commits mailing list