[PATCH] D35334: ThinLTO Minimized Bitcode File Size Reduction

[Haojie Wang via Phabricator via llvm-commits]

haojiewang added inline comments.


================
Comment at: lib/Bitcode/Writer/BitcodeWriter.cpp:4031
+
+  writeModuleInfo();
+
----------------
pcc wrote:
> With this call you're emitting a lot of unnecessary information into the minimized bitcode file. As I was suggesting on the other thread I wonder whether you can just emit "short" module-level records that just contain the name and the linkage (maybe see if you can drop the linkage, as it should already be available in the summary).
Yes, this is what I'm going to do after this patch released. So do you suggest I do it in this patch or leave it to next patch?


================
Comment at: test/Transforms/ThinLTOBitcodeWriter/no-type-md.ll:40
 ; CHECK: !llvm.dbg.cu
 ; NODEBUG-NOT: !llvm.dbg.cu
+; NODEBUG-NOT: IDENTIFICATION_BLOCK_ID
----------------
pcc wrote:
> This part of the test is no longer relevant.
You mean that I'd better write a new test file, right? Along with the llvm-lto2 test.


https://reviews.llvm.org/D35334