[PATCH] D35334: ThinLTO Minimized Bitcode File Size Reduction

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini added inline comments.


================
Comment at: include/llvm/Bitcode/BitcodeWriter.h:89
+    ///
+    /// Index is required non-null.
+    /// 
----------------
haojiewang wrote:
> mehdi_amini wrote:
> > Use a const reference then?
> But M is actually also required non-null. I just used the same args list with writeModule. So here using const references instead of pointer is better?
I believe references carry the non_null information explicitly as part of the API.


https://reviews.llvm.org/D35334