[llvm] r306058 - [ORC] Switch the object layer API from addObjectSet to addObject (singular), and

Andres Freund via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 6 19:08:51 PDT 2017


On 2017-06-24 15:07:58 -0700, Andres Freund wrote:
> Hi,
> 
> 
> On 2017-06-22 21:06:55 -0000, Lang Hames via llvm-commits wrote:
> > +  /// @brief Functor for receiving object-loaded notifications.
> > +  using NotifyLoadedFtor = std::function<void(ObjHandleT, const ObjectPtr &Obj,
> > +                                              const LoadedObjectInfo &)>;
> > +
> 
> I think this is wrong, LoadedObjectInfo here refers to
> llvm/DebugInfo/DIContext.h's llvm:LoadedObjectInfo rather than, as I
> think was intended, RuntimeDyld::LoadedObjectInfo.  Or am I missing
> something?

Ping!

Andres


More information about the llvm-commits mailing list